search

econ-ark / HARK

Heterogenous Agents Resources & toolKit
Apache License 2.0
331 stars 198 forks source link

checkConditions runs automatically and prints output to screen #699

Closed mnwhite closed 3 months ago

mnwhite commented 4 years ago

Solving an IndShockConsumerType automatically prints output to screen. This is absolutely not what we want to happen.

sbenthall commented 4 years ago

I believe this is connected to #283 At the end of that issue is a proposal for a new design for logging that has passed @llorracc 's review.

mnwhite commented 4 years ago

Whoops, I forgot we had already discussed this.

On Tue, May 26, 2020 at 12:31 PM Sebastian Benthall < notifications@github.com> wrote:

I believe this is connected to #283 https://github.com/econ-ark/HARK/issues/283 At the end of that issue is a proposal for a new design for logging that has passed @llorracc https://github.com/llorracc 's review.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/econ-ark/HARK/issues/699#issuecomment-634135303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKRAFNL5IMCWDWJ25CFC2DRTPVH7ANCNFSM4NKQSS3Q .

sbenthall commented 4 years ago

it's all good. Thanks for reminding me I need to fix it

sbenthall commented 4 years ago

@mnwhite I think you and @llorracc may have a design disagreement here?

https://github.com/econ-ark/HARK/issues/283#issuecomment-600279552

I think that @llorracc wants checkConditions to normally print some, but not all, of the messages when IndShockConsumerType is solved(). He has asked that the "quiet" option be something that can be set for individual notebooks.

If I understand you correctly, I think you are saying here that you think that turning on the print statements for checkConditions should be opt in.

From my perspective, this is a matter of deciding which of three proposed logging settings (normal, "verbose", or "quiet") is the default. I have no opinion on this.

I'll get the flexible logging framework described in #283 in as a PR and let you and @llorracc hash out the details here, since it seems to be mainly a question of how best to address the tensions between pedagogical and research use cases.

mnwhite commented 3 months ago

This was fixed long ago, closing.