econchick / interrogate

Explain yourself! Interrogate a codebase for docstring coverage.
https://interrogate.readthedocs.io
MIT License
562 stars 46 forks source link

feat(pre-commit-hooks): add setuptools to additional dependencies #163

Closed ericmjl closed 3 months ago

ericmjl commented 8 months ago

Hey, I just made a Pull Request!

Description

This PR adds setuptools to the additional dependencies in the pre-commit-hooks.yaml file. This change ensures that setuptools is available during the execution of pre-commit hooks, which can be crucial for certain Python hooks that rely on setuptools.

Motivation and Context

Resolves #162

Have you tested this? If so, how?

I have not yet tested this change, but based on reading the documentation, I have moderately high confidence that this is the right fix for #162.

Checklist for PR author(s)

Release note

Add `setuptools` to the additional dependencies in the pre-commit-hooks.yaml file.
This change ensures that setuptools is available during the execution of pre-commit hooks,
which is explictly needed when running with Python 3.12.
diazona commented 8 months ago

(I'm not involved with this project, just a curious person who followed links from your blog post)

I came here to suggest that switching from pkg_resources to importlib.resources would be a more "proper" fix in the long term - a lot of people seem not to know about importlib.resources as a replacement for pkg_resources. But it looks like that's already been done in commit 3aa94a6a9d6dca0a015d97ef389feb788cb466dd. So I suspect this change may not be needed anymore.

ericmjl commented 8 months ago

Ah! That is something I didn’t know! Thank you very much, @diazona, I definitely learned something new today.

ericmjl commented 3 months ago

@econchick i think we can close out this PR, no need to merge it. What do you think?

econchick commented 3 months ago

@ericmjl agreed - ty!