search

econchick / interrogate

Explain yourself! Interrogate a codebase for docstring coverage.
https://interrogate.readthedocs.io
MIT License
574 stars 44 forks source link

Remove redundant tests #57

Open s-weigand opened 4 years ago

s-weigand commented 4 years ago

Description

Since black is in your .pre-commit-config.yaml, having extra formatting tests is redundant + you would have to manage its version in two more places. As for running pre-commit run -a locally, this will be done on staged files by the installed hook. On the CIs 'Pre-commit' job all files will be tested and since it utilizes caching the tests should overall finish faster.

Motivation and Context

Failing CI tests du to check with an older version of black see #54

s-weigand commented 4 years ago

Removing the CI restriction on push, to only run on master, would allow contributors to see the CI results on their forks feature branch before submitting a PR.

https://github.com/econchick/interrogate/blob/35f0733aff9f42b32ad4ec26ea42819dc709adfa/.github/workflows/windows.yml#L5

https://github.com/econchick/interrogate/blob/35f0733aff9f42b32ad4ec26ea42819dc709adfa/.github/workflows/main.yml#L8