search

econchick / new-coder

New Coder tutorials
zlib License
597 stars 394 forks source link

corrected formatting in dataviz part 1 #156

Closed mukulrawat1986 closed 9 years ago

mukulrawat1986 commented 9 years ago

Corrected the formatting in the dataviz tutorial part 1, there is a big jumbled mesh in between the text which was corrected.

econchick commented 9 years ago

Thanks @mukulrawat1986 ! Would you mind making it as one commit, rather than 5? You can do that easily by rebasing ([howto here][https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/]) then force-pushing to your repo again; it'll auto-update the PR. Once that's done I'll review all the changes.

mukulrawat1986 commented 9 years ago

I have squashed the commits into one, i hope this works. Thanks @econchick

econchick commented 9 years ago

Yeah in line with what @merwok mentioned, that last code example you edited, there was a reason for all the spacing - to show the scope of the function. And it's typical/PEP8 compliant to have 4 rather than 2 spaces.

mukulrawat1986 commented 9 years ago

Thanks @merwok and @econchick , i have corrected the indents in the code.

ProProgrammer commented 9 years ago

Hey, I was going through dataviz part 1 tutorial and I noticed the formatting is still improper. i was wondering when this commit will be merged into master.

econchick commented 9 years ago

Thanks for the nudge, @ProProgrammer ! I'll look into reviewing & merging it this weekend

ProProgrammer commented 9 years ago

:+1:

mukulrawat1986 commented 9 years ago

Hey @econchick can you review and merge the commits

econchick commented 9 years ago

I can't if it's closed :) sorry for the delay and thanks for the reminder.

mukulrawat1986 commented 9 years ago

@econchick sorry, i didn't know that i closed it. I have reopened it.

econchick commented 9 years ago

Merged & deployed - thanks for the ping and the pull request!