search

econchick / new-coder

New Coder tutorials
zlib License
597 stars 392 forks source link

Typo fixes that can mislead the reader #193

Closed santosh closed 8 years ago

santosh commented 8 years ago

Commits contain typo fixes that can mislead the reader. If you feel they are correct, merge them.

I have read this book/manual till dataviz part 2. So fixes till there only. If I read it more later, I will submit another pull request.

econchick commented 8 years ago

I'm also very disinclined to accept any PRs from @santosh after this tweet cc @merwok

merwok commented 8 years ago

I agree that the tweet is in bad taste. PRs get reviews and thanks, but we’re doing this on our free time. If santosh shows more goodwill in future PRs, I will gladly review them.

santosh commented 8 years ago

Woo! That's great. You people have been judgemental after a tweet. That's cool.

merwok commented 8 years ago

Yes, people can have reactions after interactions in a PR or tweet.

I closed the PR because the changes are IMO not improvements. As I said, I will look at other PRs from you without prejudice.

santosh commented 8 years ago

Well, what are plans for Python 3 though? Are we going to adapt it, or not?

If so, are we going to make present code compatible in both 2 and 3 (which I think will be cumbersome for the readers at beginner level)? or just support 3?

There are multiple compatiblity related pulls too, I guess.

PS: I am aware that twisted is not yet ported to Python 3 yet.

econchick commented 8 years ago

@santosh I think how I'd like to approach this is have essentially two versions of each tutorial, one for py2 and one for py3. Then the reader can toggle what s/he wants to learn.

santosh commented 8 years ago

So let's start?

econchick commented 8 years ago

@santosh I'm very strapped for time. I'd happily review pull requests, and I'm sure @merwok as well. Perhaps start with the actual code first?

santosh commented 8 years ago

@econchick What about the pulls already addressing Python 3?

182 will probably die, because it just replaced the Python 2 code. What about #157?

econchick commented 8 years ago

You can see that neither of those actually have separate codebase for the tutorials, it just makes the current tutorial code compatible, which as you said, can be confusing to the reader. It may be a good start to pull those PRs and work off of that.

santosh commented 8 years ago

I didn't understand?