search

econchick / new-coder

New Coder tutorials
zlib License
597 stars 392 forks source link

API tutorial - giantbomb API now requires user agent #200

Open nickdavidhaynes opened 8 years ago

nickdavidhaynes commented 8 years ago

Was taking a look at the API tutorial and kept getting 403 return when calling the giantbomb API. Googling uncovered this forum post from a month ago - http://www.giantbomb.com/forums/api-developers-3017/api-call-throws-error-403-forbidden-1496714/?page=1#js-message-8232912

Looks like giantbomb API now requires a (arbitrary) user agent. Adding this line fixes the 403.

merwok commented 8 years ago

LGTM, thanks for the report and patch!

skadiet commented 7 years ago

I was going to add some similar code to ensure that people knew they had to use a user-agent for the giatbomb api. As of a couple days ago, @nickdavidhaynes 's changes hadn't been pulled into @econchick 's master branch. Are there any plans to do this? How does that work?

merwok commented 7 years ago

I tend to give feedback on PRs but leave the final review and approval to @econchick