econchick / new-coder

New Coder tutorials
zlib License
597 stars 392 forks source link

Push updates to newcoder.io #43

Closed parezcoydigo closed 11 years ago

parezcoydigo commented 11 years ago

In reading through Dataviz Part 1 - Parse, I noticed there were a number of typos and other problems that have been fixed in the Github repo, but never pushed to the static site. For example, the site still has:

with open(raw_file) as opened_file:

which doesn't match the final versions of the script. (That syntax can cause problems when playing on the CLI if the user doesn't put the rest of the csv.reader code in a block under the line, as it automatically closes the file and therefore the csv stream.) There are other examples as well:

def parse(raw_file, delimiter):
    """Parses a raw CSV file to a JSON-line object"""

    # Open CSV file
    open_file = open(raw_file)

    # Read the CSV data
    csv_data = csv.reader(opened_file, delimiter=delimiter)

There's a typo, with open_file and opened_file describing the same object.

There's also no lib directory in the Github repo. I imagine in the rest of the tutorials there may be similar problems solved by pushing the fixed markdown files to your site generator.

I like them very much, BTW!

econchick commented 11 years ago

Thank you @parezcoydigo ! I pushed an update - hopefully I got the typos.