econchick / new-coder

New Coder tutorials
zlib License
597 stars 394 forks source link

(scrape) removed deprecated code #93

Closed nikhgupta closed 6 years ago

nikhgupta commented 10 years ago

Hello, a lot of things had been deprecated by Scrapy project, since the last tutorial update. I went through the code and the documentation to use the recommended changes.

merwok commented 10 years ago

Hello, thanks for the patch! Do you think the documentation about getting set up should mention explicitly the minimum version needed for Scrapy?

nikhgupta commented 10 years ago

I wanted to use Scrapy, which is the reason why I picked up Python and the NewCoder tutorial. I appreciated how easy it was for me to get started following the tutorial. And, therefore, I would say: a simple warning stating something along the lines that scrapy is continuously improving and may emit some deprecation warnings (could be explained) with the current tutorial - should be fine. Most new coders would care less about what particular version is being used, as long as the tutorial works, and they get to learn something, IMHO.

I learned from the tutorial, and then, tried to fix the code/docs as per my understanding.

merwok commented 10 years ago

Thanks for the useful feedback. I’ll let @econchick decide if she wants to add a simple warning like you suggest to the docs.