There should be no hardness at <self_piercing>.

economidis-nick / createXSDforxMCF

2 stars 2 forks source link

There should be no hardness at <self_piercing>. #50

Closed DrCaFr closed 3 years ago

DrCaFr commented 4 years ago

Spec mentions only 5 attributes to <self_piercing>: grafik
but xmcf_3_1_0.xsd contains:
grafik

economidis-nick commented 3 years ago

not a bug: hardness under self_piercing rivets was kept only to support reading files of v3.0.0 (which had no xsd). hardness is not allowed under self_piercing_rivet for v3.1.x. There is an assertion for that. There are also files in test suite that assert that hardness is now only allowed under :

test_suite/invalid_files/rivet_self_piercing_hardness_greater_version_v300.xml
test_suite/valid_files/rivet_self_piercing_hardness_version_v300.xml

DrCaFr commented 3 years ago

Thank you, @economidis-nick, for the recherche! With commit 3ba2781, I added an according footnote 13 on page 39. Closing this issue, now.