Thanks & Features

[esticle]

Hi,

As a newbie Torque user I just want to thank the author for this! I much prefer self-hosted solutions such as this - I got my encopy-torque going today without any issues, thanks!

On to that pesky-stupid-user-requests-thing, it would be nice:

• To see where-you-were-when, the 'official' viewer implements this roughly with the marker moving on the map but it would be nice to know at what point you were at exactly what time.
• The 'official' viewer seems to identify what OBD values you have selected to upload and plot's those automatically, whilst here we have to chose which TWO to plot - whilst plotting several X and Y-axxis's are probably hell on earth it would be nice to see which choices are available (which you have uploaded) vs. the standard bunch in the drop-down menu..

Thanks again for a excellent tool!

[m4rcu5]

Hi,

I would give a big +1 on this one. Thanks for the effort into this app!

Syncing the data with points on the map, and/or even aan bigger graph display would be great.

Would it also be possible to import from csv files? For example the tracklogs of torque, live logging is not always possible.

Thanks!

[econpy]

Thank you everyone. Every feature that has been proposed is one I've wanted to add and am on board with doing.

Next week after I wrap up some stuff at work, I'm going to dive into these and knock them out. Right now the suggestions I have are:

• Proper unit conversions
• Hover functions that coordinate points on the map with point on the chart
• CSV upload

Then there are also some suggestions that will require changing the UI a bit:

• Ability to plot as few as 1 series and as many as N, where N is the total number of logged OBD parameters. I don't want to do this like the official viewer whereby the default plot has every series. This just looks way too cluttered and unreadable in my opinion.
• Larger map. This is related to the point above as the chart and map share space. Perhaps I should follow what the official viewer does here and have the default view be a full map with a button to popup the charts.

Please feel free to voice your opinion on these points. I'd like to hear what you folks would like to see in this/our viewer.

Moreover, how do you feel about the table of stats? Do you like having it? If so, are there particular stats/calculations you'd like to have other than the basic summary statistics I've included this far?

How do you like the data export functionality? I made the CSV export such that it could easily be read into a Python pandas DataFrame via something like:

from pandas import read_csv
df = read_csv("https://data.mattnicklay.com/torque/export.php?sid=1404105073278&filetype=csv")

Would you use an export button that exports every session at once into a single file? This would be pretty easy to add.

Let me know what you think! --Matt

[m4rcu5]

Hi Matt,

In response to your suggestions;

• To plot them all indeed doesn't make a lot of sense, maybe you can plot 1 or 2 sensible defaults which are also supported by the most basic ECU's (e.g. speed/rpm vs distance or time).
• I think the layout of the official viewer isn't bad (except for the plot them all strategy). The current graph should definitely grow.

I am not using the stats in my case, i might be interested in averages/min/max though, this is already implemented, but maybe make the table hideble.

What are you doing with the exported data, currently my use case is aimed toward getting CSV data from the ECU to a graph instead of the other way around. Dumping all at once could be useful, but after a year of driving i could imaging the dumps grow somewhat wealthy.

--Marcus

[esticle]

Have to echo m4rcu5 and thanks econpy!

• Agree that plotting one or two (speed/rpm vs time) makes sense with the option of course to plot what you want otherwise
• I also like the official viewer's layout other than plotting everything, a time-/distanceline at the bottom with a bigger map is most definitely preferred
• Also, could the points between GPS points be averaged rather than be straight lines? What I mean is that position points are quite 'edgy' compared to a smoother view between points on the official viewer?
• The stats I also do not use much but the min/max/avg values already given looks good to me
• With regards to data and import/exports, I figured i would always have roughly a year's worth online for reference and find a way to export-per-session back into csv anything older than X days/months/years so it can easily be re-imported if required again. Admittedly I've not looked at the scripts/ directory yet or worried about it yet since it's such a new install :)

--Esticle

[mo5245]

Features and thanks

• Check box for chart/stats to ignore and not plot some of the default values like 0, 32.
• Ability to select different user/car probability base off the email as the profile name dose not seem to log well.
• UI idea have a panel drop down at Select 2 Variables to Plot with a grid of check boxes for variables, check the ones your interested in and they list in grouping chart rows section (chart 1,chart 2,chart 3 ) and plot X number of charts and stats. and or allow 4 or 6 variables per chart and have radio buttons on sides of chart(s) to alternate and some way to select variable side.maybe drag and drop if not too slow.

[econpy]

Good suggestions. Thanks for the continued constructive feedback.

1 is very do able and I value the problem it solves. #3 gives me some good ideas about what to make the new charting functionality look like. I'll work with this.

Can you expand on #2? Do you want to be able to split/group your sessions into different profiles? Based on how profiles work in Torque, a profile should be synonymous with a car. So if a user has more than one car this is definitely necessary. An email isn't necessarily synonomous with a person (where a person is someone who can have 1 or more car). There is an id hexidecimal variable that is better suited for this. Let me know what you were thinking here.

By the way, I started working on the defaultUnit/userUnit stuff and it is coming along well so far. Should be ready to push in a couple days.

[mo5245]

For second bullet, not having to run multiple instances. cursory look at the sql db (when adding MAF and Voltage fields) profile name only logged once at the top of the session (feature or bug in torque), which should be enough. eml (email field) could be used to differentiate from two different devices but using the profile name should work just fine to differentiate from multiple cars or as a group e.g. daily driving, track day.... (long pause) and then at some point being able to compare sessions with sessions or with session profile (working title for this feature) as this complicates every thing it can wait till the main mode is more complete and maybe an advanced mode depending on how the UI scales to not inconvenience any one off graph usage.

And a quick example of third bullet

[smackYYZ]

Question, can I easily add other data such as gear, throttle, etc that I have displayed ?

Looking at the db schema seems the data fields are hard coded. So is all available data being uploaded or just the selected fields in the DB? And how would I go about best adding more fields?

Great project & work, much appreciated!

Mike

[mo5245]

Worked for me when I added kff1238 (voltage) and k10 (MAF) and you have to added it to torque logging and upload, select what to log, preferences just put a k in front of the PID. Easy to add with phpmyadmin or use ALTER TABLE via mysql CLI

``

[econpy]

If the PID starts with k, then there is no need to manually modify the database schema. Just select it in Torque and when it gets posted to the webserver it will create a column for the PID. Take a look at the upload_data.php script to see how the logic works. Basically, if the PID/key matches "v", "eml", "time", "id", "session", or anything starting with a "k", it will work. It does regular expression matching on these PIDs.

This matching will change a bit when I finish the default unit conversions as I'll begin accepting defaultUnit* keys and userUnit* keys under special circumstances (first data logs of a session).

[econpy]

I just added one of the requested features in the beta branch. Namely, I added a button to toggle width of the map by hiding the charts/data in the right hand column. Here are two pictures showing what the toggle button does:

Default (Toggle Off):

Toggle On:

You can add this to your current build by swapping out the session.php and static/js/torquehelpers.js files from the beta branch into your current build.

As mentioned yesterday, the beta branch changes the db schema in order to handle dynamic unit conversions (temperature and speed units) and is not backwards compatible with your old logs as right now due to the non-existence of necessary logs for profile/userUnit/defaultUnit items (these are dropped by the upload_data.php script in the master branch). Once I have a way to add backwards compatibility, I will merge the beta branch into the master branch, but for now it is best to leave them separate in order to prevent confusion/issues.

[pjvenda-zz]

Hi econpy, many thanks for your work, this is something I have been looking for for a while. I have not found telemetry software that is generic enough to take in a .csv with various parameters and I am not keen on uploading my driving logs to a shared server for many reasons.

I have not tried the software but from the demo it is, in my view nearly perfect. I would suggest only a couple of improvements related to this thread:

• the ability to zoom in on a portion of the graph and corresponding segment on the map to analyse a portion of data;
• the ability to view point data at specific points on the map (discussed above);
• the ability to colour the map route/track according to one of the parameters (speed, rpm, X);

Again many thanks for the great work on this piece of software, it is very useful for us petrolheads together with torque.

Cheers, Pedro.

[deennoo]

thanks for your job !