search

econpy / torque

A set of tools used with the Torque app for Android to store OBD2 data in MySQL, view GPS data from Torque on a map in real time using the Google Maps JavaScript API, plot OBD2 data in time series charts, and export the data to CSV or JSON.
MIT License
285 stars 120 forks source link

3 changes #20

Open tsohr opened 10 years ago

tsohr commented 10 years ago
econpy commented 10 years ago

I'm looking through your changes and will be able to accept a few of them. I'm not done yet, but all 3 of your bullet points are items I think are good suggestions.

I did notice 2 problematic changes that you made though in other files:

  1. The PIDs you added to torque_keys.csv here already exist in that file, although they do not have the '0' after the 'k'. In the request Ian's app does to the upload_data.php script, keys of the form k0[0-9a-f] do not include the 0.
  2. The setting of the timezone change you made here works if and only if the user is on the same timezone as the server. The PHP expression ini_get('date.timezone') will return the timezone of the server. For people using hosting services like iPage, this will make all their timestamps render in the timezone of iPage's server. The method I have in place already uses JQuery to get the timezone of the user, based on the computer they are sitting at, and then passes that to PHP as a session variable called time. One downside of my method is that it causes the page to refresh right after visiting the session.php page (the first page load is when JQuery grabs the timezone of the users computer, then it refreshes the page and passes the correct timezone to PHP on the second load). For reference, my solution comes from this stackoverflow answer. If you have a better solution that will work universally for all users of any server configuration, I'm all ears.

I'll follow up with more and accept some cherry-picked commits from your pull request shortly.

By the way, thanks for actively helping out and coding some of the features yourself. Don't get me wrong, everyone who simply suggests/asks for features here helps me out a great deal, but including working code with the feature is ideal -- it's definitely how we'll all get this viewer to a state that exceeds the official one!

TwinMist commented 9 years ago

would love to see the InfoWindow added :-)