search

econpy / torque

A set of tools used with the Torque app for Android to store OBD2 data in MySQL, view GPS data from Torque on a map in real time using the Google Maps JavaScript API, plot OBD2 data in time series charts, and export the data to CSV or JSON.
MIT License
282 stars 119 forks source link

PHP short tags in map.php #4

Closed samuelmr closed 10 years ago

samuelmr commented 10 years ago

The issue #3 was related to PHP short tags (<? instead of <?php).

Since there are good reasons to disable the short tags (e.g. XML processing instructions are using <? syntax), you should avoid using them. The torque.php file is fixed but short tags still exist in map.php

I suggest changing the following lines: var xlat = <?=$centerlat?>; var xlng = <?=$centerlong?>; var path = [<?=$imapdata?>]; to var xlat = <?php echo $centerlat; ?>; var xlng = <?php echo $centerlong; ?>; var path = [<?php echo $imapdata; ?>];

econpy commented 10 years ago

This was fixed a while back. Closing the issue in an effort to do some cleanup.