search

ecor / geotopbricks

Development version of CRAN R package geotopbricks (http://cran.r-project.org/web/packages/geotopbricks)
GNU General Public License v3.0
3 stars 1 forks source link

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #1

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.

ecor commented 1 year ago

Thank you @rsbivand , I will proceed as soon as possible.

rsbivand commented 1 year ago

You will be aware, for example from: https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html, https://r-spatial.org/r/2023/04/10/evolution3.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1 that rgdal, rgeos and maptools will be retired this year, in October 2023.

You use rgdal::showWKT in line 121 in writeRasterxgeotop.R, but have you re-visited the RRASTER format, which was updated in raster and terra (the latter uses the GDAL driver) to handle proper WKT2-2019 representations? You probably do not need rgdal at all.

Please fix by best June, latest October 2023.

ecor commented 1 year ago

Thank you @rsbivand for your message and your suggestions. I just pushed on this Github repo an updated new version no more dependent on rgdal . I will perform further checks and I will submit this version to CRAN by this month.

rsbivand commented 1 year ago

@ecor Please try to move to CRAN submission very soon. Less than three months remain to retain this package on CRAN.