ecordell / pymacaroons

A Python Macaroon Library
pymacaroons.readthedocs.org
MIT License
79 stars 23 forks source link

Warnings from setuptools and tests #61

Open arkamar opened 1 year ago

arkamar commented 1 year ago

I am testing this project with Python3.{10..12} in Gentoo and I see two warnings which might be worth of addressing before next release. First one is from compilation phase:

>>> Compiling source in /var/tmp/portage/dev-python/pymacaroons-0.13.0_p20230528/work/pymacaroons-78c55c1d33a0b23ddc71140a9c999f957d79e9dd ...
 * python3_10: running distutils-r1_run_phase distutils-r1_python_compile
 *   Building the wheel for pymacaroons-78c55c1d33a0b23ddc71140a9c999f957d79e9dd via setuptools.build_meta:__legacy__
gpep517 build-wheel --backend setuptools.build_meta:__legacy__ --output-fd 3 --wheel-dir /var/tmp/portage/dev-python/pymacaroons-0.13.0_p20230528/work/pymacaroons-78c55c1d33a0b23ddc71140a9c999f957d79e9dd-python3_10/wheel
2023-05-28 10:14:58,017 gpep517 INFO Building wheel via backend setuptools.build_meta:__legacy__
/usr/lib/python3.10/site-packages/setuptools/dist.py:755: SetuptoolsDeprecationWarning: Invalid dash-separated options
!!

        ********************************************************************************
        Usage of dash-separated 'description-file' will not be supported in future
        versions. Please use the underscore name 'description_file' instead.

        By 2023-Sep-26, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.

        See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
        ********************************************************************************

!!
  opt = self.warn_dash_deprecation(opt, section)

and the second one is from tests

tests/functional_tests/encrypted_field_tests.py::TestEncryptedFieldsMacaroon::test_encrypted_first_party_caveat
  /usr/lib/python3.12/site-packages/_pytest/fixtures.py:902: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  tests/functional_tests/encrypted_field_tests.py::TestEncryptedFieldsMacaroon::test_encrypted_first_party_caveat is using nose-specific method: `setup(self)`
  To remove this warning, rename it to `setup_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    fixture_result = next(generator)

Same warnings are printed for all mentioned python versions, the test warning is emitted for almost all tests.

ecordell commented 1 year ago

Thanks for the heads up!

I'm open to PRs to fix this, otherwise I will get to it when I can.