search

ecosse3 / nvim

A non-minimal Neovim config built to work most efficiently with Frontend Development
GNU General Public License v3.0
1.25k stars 110 forks source link

Get rid of inline errors/warnings #66

Closed techapostle closed 2 years ago

techapostle commented 2 years ago

Ideally this should be a toggle, but inline warnings and errors can really clutter up the buffer. These errors and warnings can be viewed via local diagnostics anyway, which appears below the buffer. Therefore I suggest keeping the inline messages disabled by default for now.

ecosse3 commented 2 years ago

Could you add this option as well to config.lua so user can enable/disable it easily from one place? I would put it as:

  lsp = {
    virtual_text = true -- show virtual text (errors, warnings, info) inline messages
  },

I would keep it by default to true anyway, because that's how it's presented on screenshots and beginners may not know at first how to toggle local/workspace diagnostics.

Please target dev branch. Then I will merge it to master with next release.

techapostle commented 2 years ago

@ecosse3 done. I will now close this pull request and open a new one to the dev branch. I will also try and see if I can implement this as a function to be toggled via a shortcut.