ecosse3 / nvim

A non-minimal Neovim config built to work most efficiently with Frontend Development
GNU General Public License v3.0
1.21k stars 109 forks source link

feat(lsp): more consistent ReactDTS filtering #97

Closed H4ckint0sh closed 1 year ago

H4ckint0sh commented 1 year ago

Don't handle jump to definition manually and take different scenarios as typescript versions in consideration.

ecosse3 commented 1 year ago

I understand it works the same way I did but it has cleaner code, so it's basically refactored?

H4ckint0sh commented 1 year ago

I understand it works the same way I did but it has cleaner code, so it's basically refactored?

I would not call it a refactor as you handling the jump manually.

ecosse3 commented 1 year ago

@H4ckint0sh Could you please change target branch to dev instead of master?

H4ckint0sh commented 1 year ago

@H4ckint0sh Could you please change target branch to dev instead of `masters? @ecosse3 Thank you for sharing your work!