ecosyste-ms / diff

An open API service to generate diffs between package releases for many open source software ecosystems.
https://diff.ecosyste.ms
GNU Affero General Public License v3.0
4 stars 1 forks source link

The diff's `zipnote` may need re-ordering #442

Open jamietanna opened 9 months ago

jamietanna commented 9 months ago

When looking at an example diff https://diff.ecosyste.ms/diff?url_1=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.0.0.zip&url_2=https%3A%2F%2Fproxy.golang.org%2Fgithub.com%2Fdeepmap%2Foapi-codegen%2Fv2%2F%40v%2Fv2.1.0.zip I see:

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/ci.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/release-drafter.yml
 Comment: 

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/generate.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/ci.yml
 Comment: 

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/lint.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/generate.yml
 Comment: 

-Filename: github.com/deepmap/oapi-codegen/v2@v2.0.0/.github/workflows/tidy.yml
+Filename: github.com/deepmap/oapi-codegen/v2@v2.1.0/.github/workflows/lint.yml
 Comment:

In these cases, the only changes between them are the versions, but we're seeing some of the orders being wrong - maybe we need to recursively sort the filenames before diffing them?

Upvote & Fund

Fund with Polar

andrew commented 9 months ago

Yeah good point, I wonder what output the underlying tool produces, it’s been a while since I looked at this service