Closed simkim closed 2 weeks ago
sorry I'd not being paying attention to this because it was a draft, hit the "ready to review" and I'll have a good look
Okay. Since I'm didn't write the code, I'll let @simkim hit the button.
Looks good to me, tests appear to be passing, @simkim is this ready for merging?
One more fix commit, If CI pass it's good to me
🚢
Thank you both!
FWIW we plan a release on Nov 8th and this would help a lot to have this merged before Oct 31 so that we can deploy/test.
@andrew is there anything we can do to help review/improve this?