improve coverage - Githubissues

ecphp / cas-bundle

CAS Bundle, a standard Symfony bundle for authentication using CAS protocol.

https://ecphp-cas-bundle.readthedocs.io

BSD 3-Clause "New" or "Revised" License

43 stars 9 forks source link

Closed IonBazan closed 4 years ago

IonBazan commented 4 years ago

This PR

[x] Filters out src/Resources directory from coverage report (recent yaml/xml -> php configuration changes decreased coverage)
[x] Adds return type hints where possible
[x] Adds more tests for controllers

Coverage (lines): 49% -> 86% MSI: 72% -> 80%

drupol commented 4 years ago

This is great !!! It was on my todo list :-)

Thanks !!!

IonBazan commented 4 years ago

Glad I could help. Great lib 😉

drupol commented 4 years ago

Glad it help you :-)