search

ecphp / cas-bundle

CAS Bundle, a standard Symfony bundle for authentication using CAS protocol.
https://ecphp-cas-bundle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
43 stars 9 forks source link

Symfony 5.1 compatibility #7

Closed drupol closed 1 year ago

drupol commented 4 years ago

In Symfony 5.1, the security and especially the Guard system has been revamped.

Read:

This issue is to keep track of the evolution and compatibility of this package with Symfony 5.1.

I had a conversation with @wouterj on Slack and this is the outcome:

MICSCHWA commented 4 years ago

Hi, I'm using your bundle for project together with Symfony 5.1. and got the deprecated message:

The "EcPhp\CasBundle\Security\CasGuardAuthenticator" class implements "Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface" that is deprecated since Symfony 5.1.

... however, I see that you already take care of the compatibility. Great job.

drupol commented 4 years ago

Hi,

Thanks for using the package! It's great to see that it's used by some other people :)

I did the branch because I also had the issue :)

I'm planning to dedicate some hours next week to finish this PR and tag a new version with full Symfony 5 and 5.1 support.

jraller commented 3 years ago

Is a release including the 5.1 functionality likely in the near future?

drupol commented 3 years ago

It's already compatible wit Symfony 5.1, there are some deprecated interfaces, but nothing that could be problematic.

Have you tried the latest release so far?

drupol commented 3 years ago

@jraller Any feedback to share?

jraller commented 3 years ago

I haven't had luck configuring it for use with API Platform 2.6+ on Symfony 5.2 yet. I've still got tests to run. The use of Caddy for the front end complicates things as by default only certain routes are handled by Symfony. I'll follow up when I know more.

drupol commented 3 years ago

Allrighty feel free to open issues, I'll do my best to help.

I also confirm that the package works for Symfony >=5.1.

drupol commented 1 year ago

Closing this issue, feel free to reopen it if you feel that something is wrong.