search

ecphp / cas-bundle

CAS Bundle, a standard Symfony bundle for authentication using CAS protocol.
https://ecphp-cas-bundle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
43 stars 9 forks source link

Upgrade to Symfony 7.0 #97

Closed smbpunt closed 2 weeks ago

smbpunt commented 8 months ago

Hello,

I was looking at what's new in Symfony 7 and trying to upgrade a small project on it, and I'm stuck because I'm using your bundle which depends on ^6.1 versions of Symfony bundles.

Nothing urgent, but is an update planned?

drupol commented 8 months ago

Hello! :)

I haven't planned to work on this yet, perhaps I can work on this at the end of March, depending on the workload I have.

However, pull request and feedback are very welcome if you feel like helping too. I guess it's just a matter of changing some values in the composer.json file...

KristinaMikhajlova commented 5 months ago

Hello! Any news? Are PR is ready ? :)

drupol commented 2 weeks ago

Working on this here: https://github.com/ecphp/cas-bundle/pull/100

Feel free to test !

smbpunt commented 2 weeks ago

I'm ready to test an upgrade from 6.4 to 7.0 and more, I just need a new tag

drupol commented 2 weeks ago

The tag will be made after I have confirmation that it works. In the meantime, perhaps you could use the version dev-push-nxkskstxvmtu (from https://github.com/ecphp/cas-bundle/pull/100)? As soon as I have some kind of confirmation from you that it works, I'll proceed with the tag.

drupol commented 2 weeks ago

Hey @smbpunt ! Got good news for me ? :)

smbpunt commented 2 weeks ago

Hey @smbpunt ! Got good news for me ? :)

Hello, I had a few minutes yesterday to install the bundle on a new Symfony 7.1 application, but for some reason the services didn't load. I'll take some time this afternoon to have a look.

drupol commented 2 weeks ago

OK keep me in touch!

smbpunt commented 2 weeks ago

Ok.

You can find a fast and easy demo here : https://github.com/smbpunt/Sf7EcPhpCasTest

There's 2 tags :

Both of them are working.

I faced one issue, but maybe it's because I'm using dev-master : There was no recipes, I had to create the config, import the routes by myself.

drupol commented 2 weeks ago

Cool !!! I will publish a tag tomorrow so we have something stable.

Regarding the recipe, I'm waiting for them to be validated at https://github.com/symfony/recipes-contrib/pull/1687 :)

Thank you !!!

drupol commented 2 weeks ago

I just pushed tag 3.0.2 :partying_face: !

I'm going to close this issue, feel free to reopen it if you feel something's no right.

Thanks for your help !!!