search

ecphp / cas-bundle

CAS Bundle, a standard Symfony bundle for authentication using CAS protocol.
https://ecphp-cas-bundle.readthedocs.io
BSD 3-Clause "New" or "Revised" License
43 stars 9 forks source link

Update composer.json for SF7 #98

Closed StudioAH closed 2 weeks ago

StudioAH commented 8 months ago

dependencies updates for symfony 7

This PR

Follows #. Related to #97. Fixes #.

StudioAH commented 8 months ago

Hi, previous version was already compatible with Symfony 6 so why not following up with 7 ?

drupol commented 8 months ago

Hello,

Why did you close the PR ?

FYI, I received a request for making it compatible with SF7 yesterday, I gave more information in the issue itself at https://github.com/ecphp/cas-bundle/issues/97

StudioAH commented 8 months ago

Hello, No testing was done for both SF 6 & 7 and the code had to be changed. Therefore I wanted to make sure this would work. But if you want to work on it be my guest because I am struggling to test it locally atm.

drupol commented 8 months ago

I'm confused.

If you open a PR against this project, I guess that's because you want some stuff to be updated in it, right?

StudioAH commented 8 months ago

Yes but your comment was right, my code was not considering the bundle to work for both symfony 6 and 7 at the same time. It needed some changes ^6.0 | ^7.0 for exemple

drupol commented 8 months ago

OK OK !

Yeah if you could reopen your PR and update to ^6.0 || ^7.0 (mind the 2 |), it could be nice, so you could tell me if it works, and if it is successful, I can cut a release and also close the aforementionned issue!

drupol commented 8 months ago

Nice! Thank you very much.

@Punt13140 Do you mind testing that branch and see if it works on your side? In case of a yes, I'll cut a new release immediately.

@StudioAH No worries about the broken tests, I'll take care of it myself.

smbpunt commented 8 months ago

I quickly tried to install the bundle in a new Symfony 7 project, and it doesn't work out of the box.

I have dependency problems with

"psr/http-message": "^1.0",

Trying to change

"psr/http-message": "^1.0|^2.0",

We have another dependency problem with

loophp/psr-http-message-bridge-bundle

which depends on "symfony/psr-http-message-bridge": "^1 || ^2"

However, it seems that the latter now follows Symfony tags since 6.4...

Import the bridge into the Symfony monorepo and synchronize releases https://github.com/symfony/psr-http-message-bridge/blob/v6.4.3/CHANGELOG.md

drupol commented 2 weeks ago

Merging this PR and continue the work in #100 !

drupol commented 2 weeks ago

Thank you both !!!