ecpolley / SuperLearner

Current version of the SuperLearner R package
272 stars 72 forks source link

add a tolerance threshold for duplicated #108

Closed benkeser closed 6 years ago

benkeser commented 6 years ago

If a method's results are not exactly duplicated, then numerical difficulties still arise (e.g., SL.glm with intercept-only model may provide a mean estimate to a different level of precision than SL.mean though duplicated does not pick up on this).

This pull request adds a tolerance level by rounding the columns of Z before checking for duplicates. I've set the default to 8 digits, which seems like a reasonable level, though further testing may reveal a more/less stringent threshold will suffice.