Some build fixes - Githubissues

ecrc / polar

Distributed-memory, double-precision, polar decomposition (QDWH/ZOLO-PD) of a dense matrix, svd (QDWH/ZOLOPD-SVD) of a dense matrix

BSD 3-Clause "New" or "Revised" License

12 stars 4 forks source link

Some build fixes #1

Closed wrathematics closed 6 years ago

wrathematics commented 6 years ago

With these changes, the package now builds with no warnings on gcc with -Wall -Wextra -pedantic. I've tried to make the commits small and self-evident so I'm hoping they will be easy to review. A brief summary of the major changes is:

Dropped elpa requirement from cmake, since that is only (optionally) used in ksvd.
Fixed some argument passing issues that were causing segfaults.

sukkarde commented 6 years ago

Thank you for your insightful comments. We were able to build QDWH with your changes after removing elpa dependencies in the CMakeLists.txt (line 192) and in src/CMakeLists.txt (line 15). Besides that, the other changes are very helpful to make the code easier to build. Please remove these dependencies, then we will merge your request. Thank you again,

wrathematics commented 6 years ago

Sorry for the delay. My email filters have been messed up, so I didn't get the ping. And sorry about the build problem. I'm actually using a different build system entirely. Basically I gave it R bindings https://github.com/RBigData/ksvd

If you're interested in collaborating on a paper on using ksvd from R in the next ~4-6 months, let me know. You can open an issue on the repo linked above, or feel free to email me wrathematics at gmail dot com.

sukkarde commented 5 years ago

Dear Drew, Please accept my apologies for the late reply. Regarding collaborating on a paper on using ksvd from R, yes sure, this is a great idea. Please let us know if anything is needed.