search

ecrin-github / rms-portal-new

RMS Portal with Python backend
MIT License
0 stars 0 forks source link

Perform searches locally instead of querying the DB #29

Closed cudillal closed 5 days ago

cudillal commented 4 months ago

The search feature (in summary-object.component.ts for example) queries the DB, while the full list of items is already loaded. Instead, the filtering could be done locally on this full list of items, removing a DB query from the component processes, thus making the app faster. Note: data updating on detached component re-attach (RouteReuseStrategy) uses the current search function with the DB query. This should be kept because the data may be modified in this case (thus requiring a DB query to get the updated data).

cudillal commented 2 weeks ago

I don't think the note is still relevant

cudillal commented 1 week ago

Note: not much to test, just check that searching works and that there is no loading animation (since no waiting for BE response)

Gerd-ECRIN commented 1 week ago

Looks good and seems to be fast (not enough items to have a stress test)