ecrin-github / rms-portal-new

RMS Portal with Python backend
MIT License
0 stars 0 forks source link

Repository organisation at DO-Instance not used #99

Closed Gerd-ECRIN closed 1 month ago

Gerd-ECRIN commented 2 months ago

The Repository organisation field at DO -> Instance level seems to be useless as a single Instance (data file) of a data object should belong to the organisation of that object. So organisation field on DO level should be sufficient.

cudillal commented 2 months ago

After discussion: rename the field to just "repository" or remove the field

cudillal commented 2 months ago

Modified to text field "repository", will be set automatically by TSD after uploading data (and can be set manually for other repositories)

Gerd-ECRIN commented 1 month ago

Fields are changed automatically after upload even when they are not empty.

cudillal commented 1 month ago

@Gerd-ECRIN We can probably assume the user entered the fields correctly before uploading to TSD, and in that case not overwrite for the non-empty fields.

Gerd-ECRIN commented 1 month ago

The question is, is the user expected to fill the fields? If yes, what content? If no, the fields should be inactive.

cudillal commented 1 month ago

Removed size and size unit fields and added a little explanatory icon for both the repository and url fields (if you hover over it you get some text). It's not so great, but I think it should be good enough for now.