search

ecrmnn / collect.js

💎  Convenient and dependency free wrapper for working with arrays and objects
https://collect.js.org
MIT License
6.54k stars 313 forks source link

Improved `first` #295

Closed maicol07 closed 2 years ago

maicol07 commented 2 years ago

Closes #294

ecrmnn commented 2 years ago

Thanks 🙌

Please add one or two new tests to prove your solution. Also, your changes fails exsisting tests, please make sure that they pass.

https://app.travis-ci.com/github/ecrmnn/collect.js/builds/245443582

maicol07 commented 2 years ago

@ecrmnn done! There's an issue regarding the build. I think that's because I've used the for...of loop, however it's the best way to fix this issue

ecrmnn commented 2 years ago

for ... of is not allowed in the ESLint config. You'll need to change your code.

maicol07 commented 2 years ago

@ecrmnn done! Tests work!