search

ecsendmail / MultiverseContagion

1 stars 3 forks source link

Expose parameter red days, add latest handbook link to readme, increase reliability of setup.R #9

Closed ashlinrichardson closed 3 years ago

ashlinrichardson commented 3 years ago

Hi All, For your review a couple minor change:

ecsendmail commented 3 years ago

On Sun, Feb 28, 2021 at 9:50 PM Ashlin Richardson notifications@github.com wrote:

Hi All, For your review a couple minor change:

  • within "simulation.js" exposed "red days" parameter within run.R (Ernie pls. verify if I got the parameter name correctly)

THE ACTUAL NAME OF THE PARAMETER IS "SYMPTOMATIC CASES" AND THE NUMBER 13.2 REFERS TO THE END OF ITS LIFE-TIME...... THE NUMBER ASSOCIATED WITH YELLOW ("INCUBATING") IS 2.2 BECAUSE ITS DURATION IS FROM 0 TO 2.2 THE NUMBER ASSOCIATED WITH BLUE ("PRESYMPTOMATIC" IS 5.2 BECAUSE ITS DURATION IS FROM 2.2 TO 5.2 - DAYS THE NUMBER ASSOCIATED WITH RED ("SYMPTOMATIC CASES" IS 13.2 BECAUSE ITS DURATION IS FROM 5.2 TO 13.2 - 8 DAYS

WE COULD HAVE THEM AS 2.2, 3 AND 8 BUT THE 2.2, 5.2 AND 13.2 IS LONGITUDINAL

  • added link in README.md to latest version of handbook (pls verify it's the correct one)

THE HANDBOOK IS HOPELESSLY OUT OF DATE, AND IS A ROUGH GUIDE TO THE STRUCTURE OF THE PROGRAM.....I THINK YOU ARE BOTH CODE READERS AND DO NOT NEED IT

  • added a try/catch statement in the setup.R that reattempts library install with an explicit URL (if not using one fails) cheers

You can view, comment on, or merge this pull request online at:

https://github.com/ecsendmail/MultiverseContagion/pull/9 Commit Summary

  • succeed if repo url reqd
  • expose red days parameter
  • update

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ecsendmail/MultiverseContagion/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGAKCTZUDTRPGMNBRNBZTDTBMTL3ANCNFSM4YL6EBBQ .

ashlinrichardson commented 3 years ago

Roger that thanks @ecsendmail ! I love the LONGDITUDINAL mindset. Just wanted to confirm, is the identification below good, before I merge in the change?

   try {
      VLinfEnd = SYMPTOMATIC_CASES; // does VLinfEnd_R exist?
    } catch {
    }

    try {
      VLonsetT = PRESYMPTOMATIC;
    } catch {
    }

    try {
      VLincD = INCUBATING;
    } catch {
    }
ecsendmail commented 3 years ago

Yes, that's it.

On Mon, Mar 1, 2021 at 3:53 PM Ashlin Richardson notifications@github.com wrote:

Roger that thanks @ecsendmail https://github.com/ecsendmail ! I love the LONGDITUDINAL mindset. Just wanted to confirm, is the identification below good, before I merge in the change?

try { VLinfEnd = SYMPTOMATIC_CASES; // does VLinfEnd_R exist? } catch { }

try { VLonsetT = PRESYMPTOMATIC; } catch { }

try { VLincD = INCUBATING; } catch { }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ecsendmail/MultiverseContagion/pull/9#issuecomment-788409499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGAKCTZ52TSSWWFJTKVYHDTBQSIDANCNFSM4YL6EBBQ .

ashlinrichardson commented 3 years ago

Thanks @ecsendmail will merge then. cheers