search

ecthiender / py-graphql-client

Dead-simple GraphQL client with subscriptions over websockets
https://pypi.org/project/py-graphql-client/
Other
37 stars 11 forks source link

Subscription parameters wrapped in "headers" attribute #28

Closed jasonkatz closed 1 year ago

jasonkatz commented 3 years ago

Hi,

I'm looking to pass some auth information in subscription parameters, but the payload for the connection initialization wraps the headers in a nested headers attribute (here, instead of passing them as-is.

This assumes that the target server looks inside a headers property on the incoming parameters - different servers handle these payloads differently. Some added flexibility to the client library will make it much more versatile and usable against various servers.

I will submit a quick PR to address this, but looking forward to hearing any thoughts!

ecthiender commented 1 year ago

Hi @jasonkatz , sorry for extremely slow response.

This library follows the Apollo Websocket protocol. (Although now deprecated). The target server you're dealing with should also support the same Apollo Websocket protocol for this client library to work.

I'm closing this issue, but feel free to ask more questions or re-open it.