search

ecto / duino

:bulb: Arduino framework for node.js
958 stars 214 forks source link

Serial port manual configurable #27

Closed setola closed 11 years ago

setola commented 11 years ago

Hello, I've added this feature to your project cause my arduino was on /dev/ttyACM0 and the library was not able to detect it.

Thank you for your work, it's awesome! Keep it going!

nmec commented 11 years ago

Thanks for posting this, got things working for me in Ubuntu. Hope this can be merged soon.

flosse commented 11 years ago

+1

ecto commented 11 years ago

Hey guys, I don't have my Arduino right now (it's halfway across the country). Can you confirm that this patch is legit? Also @setola, could you clarify the README section I commented on? I'll push this to npm afterward!

ecto commented 11 years ago

Also it appears there is a merge conflict after merging https://github.com/ecto/duino/pull/26 :persevere:

setola commented 11 years ago

I think that the conflict on #26 is because i forked the project before the #26 was committed.

setola commented 11 years ago

Conflict should be solved on 99dc318 commit, I've also improved documentation of 'device' parameter. Hope notthing is missing...

cheers

bigmonkeyboy commented 11 years ago

This works really well... +1 to merge.

anpross commented 11 years ago

oh well - should have checked the pull requests first - i just build my own patch to fix the same problem...

poul-kg commented 11 years ago

Why fixes by @setola are still not merged? Is this project dead?

setola commented 11 years ago

try to ping @ecto to see if he's not so busy as usually :) :) :+1:

ecto commented 11 years ago

Merged and pushed to npm @ 0.0.9. Thanks @setola!

setola commented 11 years ago

again a big thank for your work @ecto grats for the new version!!!