search

ecto / duino

:bulb: Arduino framework for node.js
958 stars 214 forks source link

Change board's ready trigger / Ensure attachment of servos #40

Open sevastos opened 11 years ago

sevastos commented 11 years ago

Thanks for your work ecto, duino is really cool and easy to get into, good job!

Anyway, this PR fixes #21.

It was a sort of racing condition where the board would sometimes trigger the ready event earlier and it should, now it listens for serialport's open event. Also I made it so that you can use servos inside the board's ready event callback. Lastly updated the board's name property to path based on serialport's.

Cheers

chrisatomix commented 11 years ago

Something's wrong here, this breaks the device: 'ACM' functionality in lib.board.js that was added here:

https://github.com/ecto/duino/commit/1dc12777607d03899b211f61c43db6b0e8c49181