Fix button down detection

ecto / duino

:bulb: Arduino framework for node.js

958 stars 214 forks source link

Fix button down detection #6

Closed richkzad closed 12 years ago

richkzad commented 12 years ago

I'm guessing du.ino was changed recently, because the button.js state detection logic was wrong in two different ways:

m[1] is actually a 2 character string, so comparing it to '0' and '1' will always fail
it had the values for up and down reversed.

It makes sense that 1 be down and 0 be up, but I'm not sure where you want the fix for the two character value.

ecto commented 12 years ago

Hey man, good catch. I waited to push the C changes to NPM because I thought something like this would come up and I didn't have time to test everything when I merged. I'll add you as a contributor :thumbsup: