search

ecto / duino

:bulb: Arduino framework for node.js
958 stars 214 forks source link

Bug in analogRead #7

Closed sbstjn closed 12 years ago

sbstjn commented 12 years ago

Hi, there is a little bug in your board.analogRead, the code should be:

Board.prototype.analogRead = function (pin) {
    pin = this.normalizePin(pin);
    this.log('info', 'analogRead from pin ' + pin);
    this.write('04' + pin + this.normalizeVal(0));
}

I'm sorry I haven't created a pull request, but my repository is too messed up right now :D

ecto commented 12 years ago

Good to hear you're hacking on duino! I'll make a fix when I get a few spare minutes

sbstjn commented 12 years ago

I've started building a framework for piping communication with duino through a WebSocket so you can build HTML interfaces and use a browser to control the Arduino. You should have a look at my Noduino project, duino is an import core component of it ;)

ecto commented 12 years ago

fixed in merge #2