ecustic / obsidian-file-color

An Obsidian plugin for setting colors on folders and files in the file tree.
MIT License
115 stars 7 forks source link

Obsidian 1.2.7 - colors are not applied #11

Closed KillyMXI closed 1 year ago

KillyMXI commented 1 year ago

Something have been changed with the recent update of Obsidian.

File color plugin is still shown in context menus and the color selection dialog remembers the color selected for a file/folder. But the color is not applied to file/folder names.

Error in the console: image

Related issue with Icon Folder extension: https://github.com/FlorianWoelki/obsidian-icon-folder/issues/170

WardF commented 1 year ago

I came here to report the same issue; I'm also observing it and am happy to provide any additional info that may be useful.

JimKnecht commented 1 year ago

@ecustic I am having the same issue as Ward and Killy

looneyapache commented 1 year ago

Same issue :)

Techno-wizard commented 1 year ago

Same issue on a linux based system

app.js:1 Uncaught TypeError: Cannot read properties of null (reading 'enabled')
    at get enabled [as enabled] (plugin:obsidian-icon-folder:3695:72)
    at eval (plugin:obsidian-icon-folder:3887:32)
    at Array.forEach (<anonymous>)
    at IconFolderPlugin.handleChangeLayout (plugin:obsidian-icon-folder:3886:38)
    at eval (plugin:obsidian-icon-folder:3797:82)
    at e.tryTrigger (app.js:1:957502)
    at e.trigger (app.js:1:957435)
    at t.trigger (app.js:1:1911307)
    at t.updateLayout (app.js:1:1903976)
    at r (app.js:1:1855474)
app.js:1 Uncaught TypeError: Cannot read properties of null (reading 'enabled')
    at get enabled [as enabled] (plugin:obsidian-icon-folder:3695:72)
    at eval (plugin:obsidian-icon-folder:3887:32)
    at Array.forEach (<anonymous>)
    at IconFolderPlugin.handleChangeLayout (plugin:obsidian-icon-folder:3886:38)
    at eval (plugin:obsidian-icon-folder:3797:82)
    at e.tryTrigger (app.js:1:957502)
    at e.trigger (app.js:1:957435)
    at t.trigger (app.js:1:1911307)
    at t.updateLayout (app.js:1:1903976)
    at r (app.js:1:1855474)
plugin:obsidian-file-color:251 Uncaught TypeError: Cannot read properties of undefined (reading 'classList')
    at eval (plugin:obsidian-file-color:251:46)
    at Array.forEach (<anonymous>)
    at eval (plugin:obsidian-file-color:250:51)
    at Array.forEach (<anonymous>)

I see it is also affection file icons plugin

DawsSauce97 commented 1 year ago

I am having the exact same problem. File colour community plugins were applied prior, and then wiped randomly. Appearance CSS Snippet codes work, as well as some other odd aesthetic community plug-ins.....just not the file colour modifying one.

Yjorch commented 1 year ago

Yep. Same issue here. After the updated from 1.1.16 to 1.2.7, the plugin is not working. I needed to go back to the old version of obsidian in order to have it working again. (New bookmarks are a nice feature, but I like more File Color plugin). Before you install again the old Obsidian version, you must remove manually the folders:

ecustic commented 1 year ago

Hey everyone, thanks for reporting the issue! I’ll take a look at it as soon as possible. Hopefully that means before the end of the week.

polyipseity commented 1 year ago

If you edit main.js to replace the last two occurences of titleEl with selfEl, then the plugin will work normally. I have submitted #13 to fix it.

ecustic commented 1 year ago

Fix is released in 1.0.3, and is available in the Obisidan community plugin browser. Thanks to @polyipseity for making the PR with the fix. 😃

JimKnecht commented 1 year ago

Awesome, thank you @ecustic and @polyipseity this is one of my main don't want to go without plugins. I appreciate all the effort writing and maintaining it.