search

ecvdbdx / github-for-fashion

MIT License
0 stars 7 forks source link

Cover #66

Closed matthieu-brillaxis closed 7 years ago

matthieu-brillaxis commented 7 years ago

Update of cover. Each user from cover.json can be use now, we just need to define how we will use them to load data for the homepage. Should we create a fake repo on a github account with a json file ?

DavidBruant commented 7 years ago

Should we create a fake repo on a github account with a json file ?

No, we'll be using this repo. Please make a separate PR with a cover.json file listing real garment repos.

Is this PR ready to be merged?

matthieu-brillaxis commented 7 years ago

I prefer to wait before merging this PR. We can watch that at the next class. I will try to make changes before the next class since I know your comments.