search

ed-software / react-material-symbols

A minimalist package for adding Material Symbols to any React project.
https://www.npmjs.com/package/react-material-symbols
25 stars 5 forks source link

SVG Icons #48

Open ed-software opened 1 year ago

ed-software commented 1 year ago

I have noticed when using this library in production that font based icons have loads of issues. Internally I have switched to using SVG based icons. There are 2 options:

  1. The next major release replaces font based icons with SVG icons
  2. Create a new library for SVG icons
mamo-muj commented 7 months ago

Hey @ed-software love the work you've done on this! Any chance of seeing the SVG icons anytime soon? Personally I'd prefer Icons being replaced with SVGIcons but maybe we could create another list to import from the package and do it that way?

So it might look something like react-material-symbols/svg/

ed-software commented 7 months ago

@mamo-muj Thanks for the kind words! I'm still interested in building this feature, but there will be some tough decisions regarding how we should handle the change. If we do end up replacing font-based icons altogether it will have to be on a new major version, since it would break compatibility with the old API. I think the best approach would be to keep font-based icons as an option you can access via something like react-material-symbols/font, since there are still some use cases for the font-based icons that SVGs don't support.

mamo-muj commented 7 months ago

@ed-software agreed! This makes sense. Thank you 🙏