search

ed33 / rcsjta

Automatically exported from code.google.com/p/rcsjta
1 stars 0 forks source link

Why only set T1,T2,T4 under mobile network #120

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In this file
https://code.google.com/p/rcsjta/source/browse/core/src/com/orangelabs/rcs/core/
ims/protocol/sip/SipInterface.java

There is a part to set retransmit timer,

        // Set timers value from provisioning for 3G or default for Wifi
        if (networkType == ConnectivityManager.TYPE_MOBILE) {
            this.timerT1 = RcsSettings.getInstance().getSipTimerT1();
            this.timerT2 = RcsSettings.getInstance().getSipTimerT2();
            this.timerT4 = RcsSettings.getInstance().getSipTimerT4();
        }

But, why only for mobile type?

Original issue reported on code.google.com by siuro...@gmail.com on 27 Jul 2015 at 11:47

GoogleCodeExporter commented 8 years ago 
There are different timers defined by 3GPP IMS spec when you are connected to a 
fix network acess or to a mobile network access.

Original comment by jmauffret@gmail.com on 27 Jul 2015 at 12:50

GoogleCodeExporter commented 8 years ago 
Thanks a lot.

And just to be curious, could you please hint me which 3gpp document mention 
the different timers of network type?

Original comment by siuro...@gmail.com on 28 Jul 2015 at 9:55

GoogleCodeExporter commented 8 years ago 
It's the following spec 3GPP TS 24.229, in the chapter "SIP timers".
So we use column 1 for fix network (timer value defined in SIP RFC in fact) and 
we use column 2 for mobile network.
So we consider the Wi-fi as a fixed network, now I m now sure to be right or 
wrong. So I will confirm with Orange experts.

Original comment by jmauffret@gmail.com on 28 Jul 2015 at 12:10

GoogleCodeExporter commented 8 years ago 
Column 1 is for network endpoint only. So timer value should be the same for 
mobile and wifi network access in the UE. I will do a patch in the integration 
branch from the new repository only at https://github.com/android-rcs/rcsjta. I 
will close the issue when it is done.

Original comment by jmauffret@gmail.com on 29 Jul 2015 at 9:15

GoogleCodeExporter commented 8 years ago 
Got it, thanks.

Original comment by siuro...@gmail.com on 29 Jul 2015 at 9:37

GoogleCodeExporter commented 8 years ago 
See bug fix at 
https://github.com/android-rcs/rcsjta/commit/b97e7b3fd0d1bae393577025c58cb18fea7
cf8be

Original comment by jmauffret@gmail.com on 29 Jul 2015 at 9:39