Closed umarcor closed 2 years ago
Merging #37 (f5b50f3) into main (736a5dd) will decrease coverage by
0.46%
. The diff coverage is96.87%
.
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 82.85% 82.39% -0.47%
==========================================
Files 9 12 +3
Lines 1476 1562 +86
Branches 236 246 +10
==========================================
+ Hits 1223 1287 +64
- Misses 192 204 +12
- Partials 61 71 +10
Flag | Coverage Δ | |
---|---|---|
unittests | 82.39% <96.87%> (-0.47%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pyEDAA/ProjectModel/__init__.py | 72.86% <71.42%> (+0.77%) |
:arrow_up: |
pyEDAA/ProjectModel/Attributes.py | 100.00% <100.00%> (ø) |
|
pyEDAA/ProjectModel/Xilinx/Vivado.py | 85.00% <100.00%> (+0.12%) |
:arrow_up: |
pyEDAA/ProjectModel/Xilinx/__init__.py | 100.00% <100.00%> (ø) |
|
tests/unit/Design.py | 95.06% <100.00%> (-4.94%) |
:arrow_down: |
tests/unit/File.py | 96.66% <100.00%> (-3.34%) |
:arrow_down: |
tests/unit/FileSet.py | 97.24% <100.00%> (-2.76%) |
:arrow_down: |
tests/unit/Files.py | 96.19% <100.00%> (-3.81%) |
:arrow_down: |
tests/unit/Project.py | 92.85% <100.00%> (-7.15%) |
:arrow_down: |
tests/unit/VHDLLibrary.py | 92.00% <100.00%> (-8.00%) |
:arrow_down: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 736a5dd...f5b50f3. Read the comment docs.
@umarcor
@umarcor as you opened the PR, I can't request a review by you :(.
As we checked most items in the sub-PRs in our meeting, I'll go on and merge it. I checked it myself 2x and fixed all open or discussed issues.
@Paebbels, it seems that the changelog here and in https://github.com/edaa-org/pyEDAA.ProjectModel/releases is missing some of the items from #38?
I updated https://github.com/edaa-org/pyEDAA.ProjectModel/pull/37 and then the release notes.
Root cause:
The items from sub-PR were not copied to the main PR for the v0.4.1 release.
New Features
Changes
.gitignore
.doc/Makefile
..coveragerc
andpytest.ini
intopyproject.toml
.Bug Fixes
manual
togh
.Integrated Pull Requests:
38
39