search

edahigure / Portfolio-setup-and-mobile-first

This project is a portafolio: the stage is setup and mobile first coding. In this version we also have the desktop aplication for the portfolio project. We use media query to give adaptavility. The idea is that a browser of small dimensions will apply the CSS code because is a mobile application.
0 stars 0 forks source link

Morning Session Week 4 Day 4 #12

Open alex1779 opened 2 years ago

alex1779 commented 2 years ago

Introduction

This is a peer-to-peer code review exercise as part of the Microverse Full-stack engineering programme.

Today we will review the last Code Branch https://github.com/alex1779/personal-portfolio-site/pull/10] submitted by @edahigure and provide feedback on things he did right and areas we feel he might need to improve upon.

alex1779 commented 2 years ago

Edhi your code looks good! Maybe you need to implement a function to close the window popup. You can do it using a function to delete that element (popup window), so that you can avoid store again and again the same element created by the dom.