Closed westrachel closed 1 year ago
@westrachel Still in the middle of testing this, but Control+C isn't killing the Grafana server for me. Is it for you?
what do you mean by grafana server? the grafana pod should still run. When you ctrl + c at the end of edamame grafana it brings you back to the next prompt in the console
Sorry I should've been clearer! Running edamame grafana
should create a port-forward to localhost:3000
, and then ctrl + c should terminate the port-forward; i.e., I should no longer be able to access Grafana at localhost:3000
. However, I'm still able to access Grafana at port 3000, even after ctrl + c.
Not sure if this is just on my end.
I'm still waiting for another cluster to re-test again, but even if that doesn't always break the connection I think it should be okay, because of the logic of kubectl.tempPortForward()
, which always checks to see if there is a port forward process before re-running kubectl port-fortward...
. So, a user should be able to re-run edamame grafana
Omg you know what I did, I had a local Grafana up and running! 😂 So I'm actually not entirely sure what happened, and I'm gonna have to test everything again. Does edamame grafana
tell you it wasn't able to run a port-forward if there's another application occupying 3000
?
Love it, LGTM!
… port forwarding, and end port forwarding where necessary
This is to address #28 and #72
Resolves #28 and #72