add visual effect when dragging the tree

edamontology / edam-browser

Stand-alone, lightweight, and fast JavaScript browser for EDAM and other ontologies

https://edamontology.github.io/edam-browser/

MIT License

13 stars 23 forks source link

add visual effect when dragging the tree #204

Closed bryan-brancotte closed 3 years ago

bryan-brancotte commented 3 years ago

Checklist

[x] I indicated which issue (if any) is closed with this PR using closing keywords
[x] I only changed lines related to my PR (no bulk reformatting)
[x] I indicated the source and check the license if I re-use code, or I did not re-use code
[x] I made my best to solve only one issue in this PR, or explain why multi had to be solved at once.

Issue

resolve #69
closes #105

Details

works in Firefox and Chrome

HagerDakroury commented 3 years ago

tested on my phone and it's working. Nice! 🎉

bryan-brancotte commented 3 years ago

working well on smartphone!

@HagerDakroury as you pointed out that it could be distracting, what do you think of not having the effect when a mouse is connected ? Similarly to #205

HagerDakroury commented 3 years ago

I'm not that bothered by the effect but I don't know how it might feel for a frequent user. Might need @matuskalas opting in here.

If it's removed for mouses though, we should add the drag cursor #105 alternatively (or along with)

bryan-brancotte commented 3 years ago

If for the both of us it's ok we can keep as is. I we get feedback on it we will open an issue to improve it