edamontology / edam-browser

Stand-alone, lightweight, and fast JavaScript browser for EDAM and other ontologies
https://edamontology.github.io/edam-browser/
MIT License
13 stars 23 forks source link

Handle CORS errors nicely when loading a custom version of EDAM #226

Open hmenager opened 3 years ago

hmenager commented 3 years ago

Current behaviour

Whenever a user loads a custom version of EDAM, if there is an error while loading the URL the UI will give no error message and no feedback: image

Suggested improvements

HagerDakroury commented 3 years ago

thamks @hmenager. A super important issue here. Also, mind passing the link you were trying to load?

hmenager commented 3 years ago

Sure, it happened to me while trying to test how MONDO would display, with this file: https://github.com/monarch-initiative/mondo/releases/download/v2021-07-12/mondo-minimal.owl But you can also test it with EDAM URLs which are not from raw.githubusercontent.com, such as: https://github.com/edamontology/edamontology/releases/download/1.25/EDAM_1.25.owl (that's important, because users might want to paste such "release" URLs directly)

matuskalas commented 2 months ago

Is this the CORS error? image