feat: Add error handling/form validation to custom version

edamontology / edam-browser

Stand-alone, lightweight, and fast JavaScript browser for EDAM and other ontologies

https://edamontology.github.io/edam-browser/

MIT License

13 stars 23 forks source link

feat: Add error handling/form validation to custom version #229

Closed HagerDakroury closed 3 years ago

HagerDakroury commented 3 years ago

Checklist

[x] I indicated which issue (if any) is closed with this PR using closing keywords
[x] I only changed lines related to my PR (no bulk reformatting)
[x] I indicated the source and check the license if I re-use code, or I did not re-use code
[x] I made my best to solve only one issue in this PR, or explain why multi had to be solved at once.

Issue

related-to #226

Details

Cleaned and commented loadTree code and removed redundant code
Added error handling when loading a custom version
Added form validation (to detect wrong format)

HagerDakroury commented 3 years ago

There is not "Request help" option for the PR ;) I pulled the cors branch, but when loading https://github.com/edamontology/edamontology/releases/download/1.25/EDAM_1.25.owl I don't get any error message. I both Chrome and Firefox I get this error in the console. Am I missing something ?

maybe you need to do an npm install first? (since I updated edam2json-js version in the process)

hmenager commented 3 years ago

There is not "Request help" option for the PR ;) I pulled the cors branch, but when loading https://github.com/edamontology/edamontology/releases/download/1.25/EDAM_1.25.owl I don't get any error message. I both Chrome and Firefox I get this error in the console. Am I missing something ?

maybe you need to do an npm install first? (since I updated edam2json-js version in the process)

It worked for me when testing, but I indeed first ran npm install.