Set a correct apns-topic value based on a push type

edamov / pushok

PHP client for Apple Push Notification Service (APNs) - Send push notifications to iOS using the new APNs HTTP/2 protocol with token-based (JWT with p8 private key)

MIT License

368 stars 119 forks source link

Set a correct apns-topic value based on a push type #101

Closed chimit closed 4 years ago

chimit commented 4 years ago

This PR addresses this issue https://github.com/edamov/pushok/issues/78#issuecomment-596448679

Based on the APNS documentation we should use different apns-topic headers for different push types. Usually just by adding various suffixes to the bundle ID. Without these changes voip, complication and fileprovider don't work.

coveralls commented 4 years ago

Coverage increased (+2.08%) to 82.267% when pulling 38505d444cb1d61fdcb34025e87ff0930eae4a71 on chimit:master into 985299054a416faee999b5e5f735957b589168a5 on edamov:master.

chimit commented 4 years ago

I'm not sure, should we put a new generateApnsTopic() method into some trait or define a parent class for auth providers to avoid code duplication? Please, review and decide.