search

edamov / pushok

PHP client for Apple Push Notification Service (APNs) - Send push notifications to iOS using the new APNs HTTP/2 protocol with token-based (JWT with p8 private key)
MIT License
368 stars 119 forks source link

PHP 8 Support #120

Closed sicaboy closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.4%) to 81.984% when pulling 532e7cd66d4dbbdcce5726db49fc305376500ed0 on sicaboy:master into ecc79d1b2382f28027bf767a9fde04303ad5d510 on edamov:master.

Venorcis commented 3 years ago

Is there an ETA on this? Looks like a very straightforward update 😁

edamov commented 3 years ago

@Venorcis Some checks were not successful on Scrutinizer. Need someone to check it. As soon as it will be successful I merge the PR

Venorcis commented 3 years ago

@Venorcis Some checks were not successful on Scrutinizer. Need someone to check it. As soon as it will be successful I merge the PR

It's failing on "PHP Analyzer: Determining Dependencies", not sure why, I don't see any error output?

edamov commented 3 years ago

I also don't see any errors. Maybe we need try to install locally composer dependencies for this PR on PHP version 8

Venorcis commented 3 years ago

I also don't see any errors. Maybe we need try to install locally composer dependencies for this PR on PHP version 8

I've just tried this using PHP 8.0.0 (cli) (built: Jan 4 2021 00:49:34) ( NTS ); it works fine! 59 packages installed succesfully.

edamov commented 3 years ago

@Venorcis Thanks! I merged and created new version 0.12.0