search

edamov / pushok

PHP client for Apple Push Notification Service (APNs) - Send push notifications to iOS using the new APNs HTTP/2 protocol with token-based (JWT with p8 private key)
MIT License
369 stars 119 forks source link

* Update dependencies to spomky-labs/jose:^7.0.0 #33

Closed ahfeel closed 6 years ago

ahfeel commented 6 years ago

This update will fetch a whole bunch of packages that are really compatible with php 7.2.

edamov commented 6 years ago

@ahfeel This update broken CI with error

ahfeel commented 6 years ago

Mhh, tests are passing successfully, even in the logs of the Travis CI. Do you have any idea why it failed ?

On Tue, Jan 23, 2018 at 5:57 PM, Arthur Edamov notifications@github.com wrote:

@ahfeel https://github.com/ahfeel This update broken CI with error

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edamov/pushok/pull/33#issuecomment-359857340, or mute the thread https://github.com/notifications/unsubscribe-auth/AACpFh0TABXUE1YBK6e2kRH9i0kCItB8ks5tNg-OgaJpZM4Rer6m .

-- Jérémie BORDIER

DFoxinator commented 6 years ago

Since this is breaking the library for PHP 7.2, maybe it's worth just bumping spomky-labs/jose to 6.1.6 which should be PHP 7.2 compatible?

DFoxinator commented 6 years ago

Sorry, my mistake, looks like unfortunately the change only made it into 7.0.

edamov commented 6 years ago

A don't have any ideas about what is wrong