edamov / pushok

PHP client for Apple Push Notification Service (APNs) - Send push notifications to iOS using the new APNs HTTP/2 protocol with token-based (JWT with p8 private key)
MIT License
369 stars 119 forks source link

Compatible with PHP7.2 ? #34

Closed jpsarda closed 6 years ago

jpsarda commented 6 years ago

It seems that the library requires spomky-labs/jose 6.1.1 which is not compatible with PHP 7.2 because it uses a custom class Object which is not allowed since PHP 7.2

Fatal error: Cannot use FG\ASN1\Object as Object because 'Object' is a special class name in ......../vendor/spomky-labs/jose/src/KeyConverter/ECKey.php on line 17

spomky-labs/jose 7.0.0 has replaced Object by ASNObject which is compatible with PHP 7.2

EDIT actually I just saw you commited it 20 days ago, so I don't understand why I'm still getting the 6.1.1 dependancy when I use php composer.phar require edamov/pushok

Sorry for the useless post.

edamov commented 6 years ago

Hi @jpsarda I commited version 7.0.0 but I didn't create new tag of pushok library because build failed. So new changes are in the master branch.

jpsarda commented 6 years ago

Thx, I got it working with the following command : php composer.phar require --update-with-dependencies edamov/pushok:dev-master

edamov commented 6 years ago

Fixed since version 0.4.1