search

edanalytics / earthmover

CLI tool for transforming collections of tabular source data into a variety of text-based data formats via YAML configuration and Jinja templates.
Apache License 2.0
19 stars 2 forks source link

Git clone timeout when running `earthmover deps` #93

Closed sleblanc23 closed 5 months ago

sleblanc23 commented 5 months ago

This PR fixes an issue with earthmover deps hanging indefinitely as it attempts to clone a private repo and waits for a user without stored credentials to enter a username and password. The git clone command will timeout after the time specified by the optional git_auth_timeout config. Default is 60 seconds, long enough to still allow a human user to enter a username and password during local development.

In making this change I was able to remove the GitPython dependency, as the git clone command is now handled by subprocess.

I tested this locally to ensure unchanged behavior when credentials are stored and I ran it in a docker container without git credentials to test the timeout.

sleblanc23 commented 5 months ago

Thanks @jayckaiser! I addressed all your comments

jayckaiser commented 5 months ago

Changing source to RC/0.3.2.

jayckaiser commented 5 months ago

@sleblanc23 Could you update the CHANGELOG file with these updates?

sleblanc23 commented 5 months ago

@jayckaiser should I do that by committing directly to the rc/0.3.2 branch?

sleblanc23 commented 5 months ago

Change log entry for when this is merged: feature: add optional git_auth_timeout config to avoid indefinite waiting for credentials when calling earthmover deps, default of 60 seconds