edanalytics / edu_edfi_airflow

Manages extract-load of Ed-Fi data in Airflow
Other
4 stars 0 forks source link

Move min_change_version fix from init to execute. #28

Closed jayckaiser closed 11 months ago

jayckaiser commented 11 months ago

Hotfix: Full-Refresh XCom Bugfix

Description & motivation

There is a bug in the current version of this repo where change-version window logic is not used during full refreshes, even if marked to be used. This is due to a bug where a conditional clause checks the XCom value of min_change_value before the Jinja template string is populated. I moved the conditional from __init__() to execute(), and the issue is resolved.

PR Merge Priority:

This is a critical bug that will affect high-volume resources. It is responsible for our inability to ingest the grades resource from the SCDE Ed-Fi ODS.

Changes to existing files: