edandersen / core-admin

Fully automatic admin site CRUD UI generator for ASP.NET Core and .NET 8
Other
560 stars 106 forks source link

Improve Performance by Providing an Option to Disable Foreign Key Drop-Downs #108

Closed mutazzuhairi closed 3 months ago

mutazzuhairi commented 3 months ago

I experiencing performance issues in the CoreAdmin interface, particularly on the "Create" tab, when dealing with entities that have foreign key relationships. The current implementation automatically generates drop-down lists for foreign key fields by querying and displaying all related records. This approach significantly impacts performance, especially when the related tables contain a large number of records.

To improve the performance and usability of CoreAdmin, we propose adding an option to disable the automatic generation of drop-down lists for foreign key fields. Instead, users should have the ability to input values as free text or leverage column data types to determine the appropriate input method. This enhancement would provide more flexibility and prevent unnecessary performance overhead associated with loading large datasets.

So, if you can Introduce a configuration setting that allows administrators to disable drop-down generation for foreign key fields and to use the column data type to determine the input method for foreign key fields.

2024-06-08 15 14 36

edandersen commented 3 months ago

Thanks for the ticket. The screenshot shows the queries taking 3ms and 6ms though?

Also out of curiosity who is "we"?


From: Mutaz Zuhairi @.> Sent: Saturday, June 8, 2024 9:16:24 PM To: edandersen/core-admin @.> Cc: Subscribed @.***> Subject: [edandersen/core-admin] Improve Performance by Providing an Option to Disable Foreign Key Drop-Downs (Issue #108)

We are experiencing performance issues in the CoreAdmin interface, particularly on the "Create" tab, when dealing with entities that have foreign key relationships. The current implementation automatically generates drop-down lists for foreign key fields by querying and displaying all related records. This approach significantly impacts performance, especially when the related tables contain a large number of records.

To improve the performance and usability of CoreAdmin, we propose adding an option to disable the automatic generation of drop-down lists for foreign key fields. Instead, users should have the ability to input values as free text or leverage column data types to determine the appropriate input method. This enhancement would provide more flexibility and prevent unnecessary performance overhead associated with loading large datasets.

So, if you can Introduce a configuration setting that allows administrators to disable drop-down generation for foreign key fields and to 2024-06-08.15.14.36.png (view on web)https://github.com/edandersen/core-admin/assets/47029836/55441cf3-91b6-41db-9205-f1bdc63b997f use the column data type to determine the input method for foreign key fields.

— Reply to this email directly, view it on GitHubhttps://github.com/edandersen/core-admin/issues/108, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEF6HGA2JB5G6QELYNTYTTZGLYZRAVCNFSM6AAAAABI76C4K6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DCNRTGAZDIOI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

mutazzuhairi commented 3 months ago

Hey @edandersen Sorry for the context, I meant me.

Yes, it took 3ms since I tried it on a small table. Is there an option to improve this functionality or to disable it?

edandersen commented 3 months ago

No there isn't an option at the moment. I accept PRs though.

If this is being used commercially please respect the license or contact me for a custom license.


From: Mutaz Zuhairi @.> Sent: Sunday, June 9, 2024 1:30:49 AM To: edandersen/core-admin @.> Cc: Ed Andersen @.>; Mention @.> Subject: Re: [edandersen/core-admin] Improve Performance by Providing an Option to Disable Foreign Key Drop-Downs (Issue #108)

Hey @edandersenhttps://github.com/edandersen Sorry for the context, I meant me.

Yes, it took 3ms since I tried it on a small table. Is there an option to improve this functionality or to disable it?

— Reply to this email directly, view it on GitHubhttps://github.com/edandersen/core-admin/issues/108#issuecomment-2156095515, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEF6HCT4YYBCMDDIZYEY6LZGMWTTAVCNFSM6AAAAABI76C4K6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGA4TKNJRGU. You are receiving this because you were mentioned.Message ID: @.***>

mutazzuhairi commented 3 months ago

No commercial use. I used it for testing my personal tools. It was just a question. I decided not to use it again; I will look for another tool. Thank you.